From e77f29b39398f6ab2312effbf3088aa16384fef8 Mon Sep 17 00:00:00 2001
From: coolneng <akasroua@gmail.com>
Date: Wed, 17 Jun 2020 04:33:48 +0200
Subject: [PATCH] Remove arguments on database connection function

---
 src/database.php             | 10 ++++++----
 src/forms/user_edit_form.php |  4 ++--
 src/user.php                 |  2 +-
 src/user_management.php      |  6 +++---
 4 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/src/database.php b/src/database.php
index 993463e..3e58d73 100644
--- a/src/database.php
+++ b/src/database.php
@@ -1,10 +1,12 @@
 <?php
 
-function connectDatabase(string $user, string $pass, string $db) {
-    $unix_socket = '.mysql/mysql.sock';
+function connectDatabase() {
+    $connection = 'unix_socket';
+    $host = '.mysql/mysql.sock';
     $charset = 'utf8mb4';
-    $dsn = "mysql:unix_socket=$unix_socket;dbname=$db;charset=$charset";
-    $pdo = new PDO($dsn, $user, $pass);
+    $db = 'practica';
+    $dsn = "mysql:$connection=$host;dbname=$db;charset=$charset";
+    $pdo = new PDO($dsn, "practica", "practica");
     return $pdo;
 }
 
diff --git a/src/forms/user_edit_form.php b/src/forms/user_edit_form.php
index 60a8b76..88263bd 100644
--- a/src/forms/user_edit_form.php
+++ b/src/forms/user_edit_form.php
@@ -10,7 +10,7 @@
     <?php
     include '../database.php';
 
-    $pdo = connectDatabase("practica", "practica", "practica");
+    $pdo = connectDatabase();
     $data = findUser($pdo, $_GET["edit"]);
     ?> <form method="post" action="../user_management.php">
         <div class="input-group">
@@ -23,7 +23,7 @@
         </div>
         <div class="input-group">
             <label>contraseña</label>
-            <input type="password" name="contraseña" value="">
+            <input type="password" name="contraseña" value="<?php echo $data[3]; ?>">
         </div>
         <div class="select-input">
             <label>rol</label>
diff --git a/src/user.php b/src/user.php
index 7920e9b..8a4ae94 100644
--- a/src/user.php
+++ b/src/user.php
@@ -22,7 +22,7 @@
             <?php
             include 'database.php';
 
-            $pdo = connectDatabase("practica", "practica", "practica");
+            $pdo = connectDatabase();
             $list = listUsers($pdo);
             foreach($list as $row) :
                     if(!$row[5]):
diff --git a/src/user_management.php b/src/user_management.php
index 75c66d2..e7df7e9 100644
--- a/src/user_management.php
+++ b/src/user_management.php
@@ -3,7 +3,7 @@ include'database.php';
 
 function userCreation(){
         $data = $_POST;
-        $pdo = connectDatabase("practica", "practica", "practica");
+        $pdo = connectDatabase();
         createUser($pdo, $data);
         closeDatabase($pdo);
         header('location: user.php');
@@ -12,7 +12,7 @@ function userCreation(){
 function userModification(){
         $data = $_POST;
         $id = $_POST["id"];
-        $pdo = connectDatabase("practica", "practica", "practica");
+        $pdo = connectDatabase();
         editUser($pdo, $data, $id);
         closeDatabase($pdo);
         header('location: user.php');
@@ -20,7 +20,7 @@ function userModification(){
 
 function userDeletion(){
         $id = $_GET["delete"];
-        $pdo = connectDatabase("practica", "practica", "practica");
+        $pdo = connectDatabase();
         deactivateUser($pdo, $data, $id);
         closeDatabase($pdo);
         header('location: user.php');